Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: inject css #40

Merged
merged 8 commits into from
Jan 24, 2024
Merged

Conversation

sadeghbarati
Copy link
Contributor

@sadeghbarati sadeghbarati commented Jan 23, 2024

This PR doesn't fix the freezing issue but fixes injecting CSS issue and improves SSR

Since we now injecting the CSS into the bundle what is should we put in package.json sideEffects field?

localhost_3000.-.Google.Chrome.2024-01-24.00-05-34.mp4

Copy link

vercel bot commented Jan 23, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
vue-sonner ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 23, 2024 8:49pm

Copy link
Owner

@xiaoluoboding xiaoluoboding left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@xiaoluoboding xiaoluoboding merged commit bcd36bd into xiaoluoboding:main Jan 24, 2024
2 checks passed
@sadeghbarati sadeghbarati deleted the feat/inject-css branch January 24, 2024 07:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants